Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Patch azure support #140

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Patch azure support #140

merged 2 commits into from
Oct 26, 2023

Conversation

vivi
Copy link
Contributor

@vivi vivi commented Oct 26, 2023

Closes #118 #91 #90

  • better validation of azure environment variables, added embeddings deployment variable too
  • have to use engine if deployment is not passed in
  • tested with computing embeddings, also deployment ids are optional

@vivi vivi requested a review from cpacker October 26, 2023 21:45
vivi and others added 2 commits October 26, 2023 14:48
Co-Authored-By: Rivaaj Jumna <50959956+rivms@users.noreply.github.com>
Co-Authored-By: Rivaaj Jumna <50959956+rivms@users.noreply.github.com>
azure_vars = get_set_azure_env_vars()
if len(azure_vars) > 0:
print(
f"Error: Environment variables {', '.join([x[0] for x in azure_vars])} should not be set if --use_azure_openai is False"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😈 love it 😈

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😈

Copy link
Collaborator

@cpacker cpacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😈 LGTM

@vivi vivi merged commit 571d15b into main Oct 26, 2023
@vivi vivi deleted the azure-patch branch October 26, 2023 21:56
mattzh72 pushed a commit that referenced this pull request Oct 9, 2024
Patch azure support

Co-Authored-By: rivms <50959956+rivms@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure embedding not possible
2 participants